Skip to content

🧹 [code health] macroize redundant Default impls#423

Merged
404Setup merged 1 commit intomainfrom
fix-default-duplication-16263648469470424942
Apr 29, 2026
Merged

🧹 [code health] macroize redundant Default impls#423
404Setup merged 1 commit intomainfrom
fix-default-duplication-16263648469470424942

Conversation

@404Setup
Copy link
Copy Markdown
Owner

🎯 What: Introduced a shared macro impl_default_new! to handle the Default trait boilerplate and applied it to Decompressor and BatchDecompressor.
💡 Why: Reduces code duplication and improves maintainability by centralizing the pattern of delegating Default::default to Self::new.
Verification: Confirmed macro correctness via standalone Rust test scripts and code review, as full crate compilation was restricted by environment constraints.
Result: Removed redundant code across three files, replaced by clear macro calls.


PR created automatically by Jules for task 16263648469470424942 started by @404Setup

Introduced a shared macro `impl_default_new!` in `src/common.rs` to
automate the implementation of the `Default` trait for types that
delegate directly to their `new()` method. This reduces boilerplate
and improves maintainability across `src/api.rs`, `src/batch.rs`, and
`src/decompress/mod.rs`.
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@404Setup 404Setup merged commit e41044a into main Apr 29, 2026
5 checks passed
@404Setup 404Setup deleted the fix-default-duplication-16263648469470424942 branch April 29, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant